pkp/pkp-lib#4787 Reviewer suggestions #10497
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
touhidurabir
force-pushed
the
i4787_main
branch
from
177b71d
to
304c66c
Compare
touhidurabir
force-pushed
the
i4787_main
branch
from
c2c4775
to
5d155f9
Compare
touhidurabir
commented
Oct 20, 2024
|
|
||
| return AuthorizationPolicy::AUTHORIZATION_DENY; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is how right now we usually setting different restriction but probably a middleware is better and cleaner approach that we should start using ?
touhidurabir
commented
Oct 22, 2024
Comment on lines
68
to
73
| public function messages(): array | ||
| { | ||
| return [ | ||
| 'familyName.required' => 'family name is required', | ||
| ]; | ||
| } |
There was a problem hiding this comment.
There are placeholder for now as part of experiment but this is what needed to be resolved as dynamic multilingual response for error .
touhidurabir
force-pushed
the
i4787_main
branch
3 times, most recently
from
0276910
to
73c1147
Compare
touhidurabir
commented
Nov 4, 2024
Comment on lines
1
to
50
| <?php | ||
|
|
||
| /** | ||
| * @file classes/migration/upgrade/v3_5_0/I4787_ReviewSuggestions.php | ||
| * | ||
| * Copyright (c) 2014-2024 Simon Fraser University | ||
| * Copyright (c) 2000-2024 John Willinsky | ||
| * Distributed under the GNU GPL v3. For full terms see the file docs/COPYING. | ||
| * | ||
| * @class I4787_ReviewSuggestions | ||
| * | ||
| * @brief Add reviewer suggestion related tables | ||
| */ | ||
|
|
||
| namespace PKP\migration\upgrade\v3_5_0; | ||
|
|
||
| use Illuminate\Support\Collection; | ||
| use PKP\migration\install\ReviewerSuggestionsMigration; | ||
| use PKP\migration\upgrade\v3_4_0\I7191_InstallSubmissionHelpDefaults; | ||
|
|
||
| abstract class I4787_ReviewSuggestions extends I7191_InstallSubmissionHelpDefaults | ||
| { | ||
| /** | ||
| * Run the migration. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| (new ReviewerSuggestionsMigration($this->_installer, $this->_attributes))->up(); | ||
| parent::up(); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migration | ||
| */ | ||
| public function down(): void | ||
| { | ||
| (new ReviewerSuggestionsMigration($this->_installer, $this->_attributes))->down(); | ||
| parent::down(); | ||
| } | ||
|
|
||
| /** | ||
| * @return Collection [settingName => localeKey] | ||
| */ | ||
| protected function getNewSettings(): Collection | ||
| { | ||
| return collect([ | ||
| 'reviewerSuggestionsHelp' => 'default.submission.step.reviewerSuggestions', | ||
| ]); | ||
| } | ||
| } |
There was a problem hiding this comment.
This should probably go to a v3_6_0 folder .
touhidurabir
force-pushed
the
i4787_main
branch
from
fed1e68
to
6c9d25b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #4787