Skip to content

Commit

Permalink
#10362 include editorName when logging an editorial decision
Browse files Browse the repository at this point in the history
  • Loading branch information
kaitlinnewson committed Nov 21, 2024
1 parent 612d1f5 commit b9f2ddd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ public function reviewRead($args, $request)
'message' => 'log.review.reviewConfirmed',
'isTranslated' => false,
'dateLogged' => Core::getCurrentDate(),
'editorName' => $user->getFullName(),
'userName' => $user->getFullName(),
'submissionId' => $reviewAssignment->getSubmissionId(),
'round' => $reviewAssignment->getRound()
]);
Expand Down
7 changes: 4 additions & 3 deletions classes/decision/Repository.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
/**
* @file classes/decision/Repository.php
*
* Copyright (c) 2014-2022 Simon Fraser University
* Copyright (c) 2000-2022 John Willinsky
* Copyright (c) 2014-2024 Simon Fraser University
* Copyright (c) 2000-2024 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
*
* @class Repository
Expand Down Expand Up @@ -237,6 +237,7 @@ public function add(Decision $decision): int
? PKPSubmissionEventLogEntry::SUBMISSION_LOG_EDITOR_RECOMMENDATION
: PKPSubmissionEventLogEntry::SUBMISSION_LOG_EDITOR_DECISION,
'userId' => Validation::loggedInAs() ?? $this->request->getUser()?->getId(),
'editorName' => $editor->getFullName(),
'message' => $decisionType->getLog(),
'isTranslated' => false,
'dateLogged' => Core::getCurrentDate()
Expand Down Expand Up @@ -378,7 +379,7 @@ abstract public function getDecisionTypes(): Collection;
abstract public function getDeclineDecisionTypes(): array;

/**
* Get a list of the decision types that a recommending user is
* Get a list of the decision types that a recommending user is
* allowed to make given a submission stage id.
*
* @return DecisionType[]
Expand Down

0 comments on commit b9f2ddd

Please sign in to comment.