ORCID plugin 2.4.8 #14

atarix83 · 2017-04-07T16:28:51Z

Hi,

I proceeded to add some features to orcidProfile plugin for OJS 2.4.x and I'd like to commit to OJS codebase.

What we have changes is :

added search functionality for additional authors;
added translation file for Italian language;
some improvements in the graphic;
bug fixes in the request email.

Thanks.
Giuseppe
4Science

Code reviewed.

asmecher · 2017-04-07T19:13:03Z

@atarix83, before I start on a code review, would you mind converting indentation to tabs instead of spaces? Thanks!

atarix83 · 2017-04-10T08:29:54Z

@asmecher
Done.

asmecher · 2017-04-20T22:53:30Z

locale/en_US/locale.xml

 	<message key="plugins.generic.orcidProfile.emailOrOrcid">Email address or ORCID iD:</message>
-	<message key="plugins.generic.orcidProfile.submitAction">Submit</message>
+    <message key="plugins.generic.orcidProfile.submitAction">Submit</message>


There are still some space-based indents here.

asmecher · 2017-04-21T02:50:57Z

locale/it_IT/locale.xml

+	<message key="plugins.generic.orcidProfile.instructions"><![CDATA[È possibile precompilare il modulo con le informazioni da un profilo orcid.  Inserire l'indirizzo email o ORCID iD associati al profilo ORCID, quindi fare clic su "Conferma".]]></message>
+	<message key="plugins.generic.orcidProfile.noData">Nessuna informazione trovata dal registro di ORCID.</message>
+	<message key="plugins.generic.orcidProfile.emailOrOrcid">Indirizzo Email o ORCID iD:</message>
+    <message key="plugins.generic.orcidProfile.submitAction">Conferma</message>


Some space-based indents

asmecher · 2017-04-21T02:51:12Z

pages/OrcidHandler.inc.php

@@ -79,7 +56,8 @@ function orcidAuthorize($args, &$request) {
 				// Submission process: Pre-fill the first author's ORCiD from the ORCiD data
 				echo '<html><body><script type="text/javascript">
 					opener.document.getElementById("authors-0-orcid").value = ' . json_encode('http://orcid.org/' . $response['orcid']). ';
-					opener.document.getElementById("connect-orcid-button").style.display = "none";
+                    opener.document.getElementById("connect-orcid-button").style.display = "none";


Space-based indents

asmecher · 2017-04-21T02:51:33Z

templates/orcidProfile.tpl

 * ORCID Profile authorization form
 *
 *}
 <script type="text/javascript">

 function openORCID() {ldelim}
 	var oauthWindow = window.open("{$orcidProfileOauthPath|escape}authorize?client_id={$orcidClientId|urlencode}&response_type=code&scope=/authenticate&redirect_uri={url|urlencode page="orcidapi" op="orcidAuthorize" targetOp=$targetOp params=$params escape=false}", "_blank", "toolbar=no, scrollbars=yes, width=500, height=600, top=500, left=500");
+	console.log(self);


I think this is a debugging leftover.

asmecher · 2017-04-21T02:53:02Z

Sorry to be so picky about indentation -- it's my obsession :)

atarix83 · 2017-04-26T08:32:53Z

Sorry for not having carefully checked, now It'd be ok

asmecher · 2017-04-26T23:30:08Z

css/orcidProfile.css

@@ -9,17 +9,22 @@
 	font-weight: bold;
 	font-size: .8em;
 	line-height: 24px;
+    margin: .3em;


Sorry, one more here :)

asmecher · 2017-04-26T23:30:17Z

css/orcidProfile.css

 	display: block;
 	margin: 0 .5em 0 0;
 	padding: 0;
 	float: left;
 }
+
+.search-content {
+    padding: 10px !important;


asmecher · 2017-04-26T23:32:26Z

@ctgraham, have you tinkered with any of this recently?

ctgraham · 2017-04-27T12:34:56Z

@asmecher, I have not done any recent work on the orcidProfile plugin.

atarix83 · 2017-06-14T10:17:04Z

Hi,
any news about this PR?

Thanks.
Giuseppe
4Science

asmecher · 2017-06-14T20:05:01Z

Sorry, @atarix83, it's been on my list to look at but I've been having trouble keeping up with other priorities. @defstat, would you be able to look at it?

defstat

@atarix83 A first review round with few suggestions.

defstat · 2017-06-25T17:17:26Z

OrcidProfilePlugin.inc.php

@@ -84,10 +92,10 @@ function setupCallbackHandler($hookName, $params) {
 	function handleTemplateDisplay($hookName, $args) {
 		$templateMgr =& $args[0];
 		$template =& $args[1];
-                $request =& PKPApplication::getRequest();
+        $request =& PKPApplication::getRequest();


Indent here?

it seems ok on my branch https://github.com/4Science/orcidProfile/blob/ojs-dev-2_4/OrcidProfilePlugin.inc.php

defstat · 2017-06-25T17:17:47Z

OrcidProfilePlugin.inc.php

-                // Assign our private stylesheet.
-                $templateMgr->addStylesheet($request->getBaseUrl() . '/' . $this->getStyleSheet());
+        // Assign our private stylesheet.
+        $templateMgr->addStylesheet($request->getBaseUrl() . '/' . $this->getStyleSheet());


Indent here?

it seems ok on my branch https://github.com/4Science/orcidProfile/blob/ojs-dev-2_4/OrcidProfilePlugin.inc.php

defstat · 2017-06-25T17:18:08Z

OrcidProfilePlugin.inc.php

@@ -97,6 +105,7 @@ function handleTemplateDisplay($hookName, $args) {
 				$templateMgr->register_outputfilter(array(&$this, 'profileFilter'));
 				break;
 			case 'author/submit/step3.tpl':
+            case 'submission/metadata/metadataEdit.tpl':


Indent here?

it seems ok on my branch https://github.com/4Science/orcidProfile/blob/ojs-dev-2_4/OrcidProfilePlugin.inc.php

defstat · 2017-06-25T17:26:07Z

OrcidProfilePlugin.inc.php

+				    });</script>';
+			    $newOutput .= substr($output, $offset + strlen($match));
+			    $output = $newOutput;
+            }


Several indentation issues at that function.

I'm not sure to what you are referring, maybe line 231?

defstat · 2017-06-25T17:27:30Z

locale/en_US/locale.xml

+    <message key="plugins.generic.orcidProfile.searchResultsList">Choose and select the exact match from the list below:</message>
+	<message key="plugins.generic.orcidProfile.searchResultsList">Choose and select the exact match from the list below:</message>
+    <message key="plugins.generic.orcidProfile.privateEmail">Not viewable</message>
+    <message key="plugins.generic.orcidProfile.noResults">No search results</message>


Some indentation issues here

It seems ok in my branch

defstat · 2017-06-25T18:55:58Z

locale/it_IT/emailTemplates.xml

+
+
+</body>
+		<description>This email template is used to collect the ORCID id's from co-authors.</description>


Is this only for 'co-authors'?

defstat · 2017-06-25T18:56:29Z

locale/it_IT/locale.xml

+<!DOCTYPE locale SYSTEM "../../../../../lib/pkp/dtd/locale.dtd">
+
+<!--
+  * plugins/generic/orcidPlugin/locale/en_US/locale.xml


en_US -> it_IT

orcidPlugin -> orcidProfile?

defstat · 2017-06-25T19:00:32Z

templates/orcidProfile.tpl

@@ -1,11 +1,13 @@
 {**
 * plugins/generic/orcidProfile/orcidProfile.tpl


defstat · 2017-06-25T19:01:46Z

templates/orcidProfileSearch.tpl

@@ -0,0 +1,23 @@
+{**
+ * plugins/generic/orcidProfile/orcidProfileSearch.tpl


defstat · 2017-06-25T19:03:31Z

templates/orcidProfileSearchResults.tpl

@@ -0,0 +1,162 @@
+{**
+ * plugins/generic/orcidProfile/orcidProfileSearchResults.tpl


defstat · 2017-06-25T19:26:55Z

templates/orcidProfileSearchResults.tpl

+			</tr>
+			<tr class="heading" valign="top">
+				<td width="5%">&nbsp;</td>
+				<td width="25%">{translate key="plugins.generic.openAIRE.projectID"}</td>


Fix translation key

defstat · 2017-06-25T19:44:53Z

locale/it_IT/emailTemplates.xml

+  * Localized email templates XML file.
+  -->
+
+<email_texts locale="en_US">


change locale

defstat · 2017-06-25T19:52:54Z

templates/orcidProfileSearchResults.tpl

+<h3>{translate key='plugins.generic.orcidProfile.searchPageTitle'}</h3>
+<div id="content" class="search-content">
+	<p>{translate key='plugins.generic.orcidProfile.searchResultsList'}</p>    
+	<form action="{plugin_url path="process"}" method="post" id="issuesForm">


Suggest change the name of the form [id="issuesForm"]

defstat · 2017-06-25T20:05:22Z

templates/orcidProfileSearch.tpl

+{rdelim}
+</script>
+
+<button id="{$params.orcidButtonId}" onclick="return openSearchORCID{$params.authorIndex}();" {if !$params.orcidButtonVisible}style="display:none;" {/if}><img class="orcid-id-logo" src="http://orcid.org/sites/default/files/images/orcid_24x24.png" width="24" height="24" alt="{translate key='plugins.generic.orcidProfile.submitAction'}"/>Search the ORCID iD</button>


suggest change "Search the ORCID iD" to {translate key='...'}

defstat · 2017-06-25T20:08:22Z

templates/orcidProfileSearchResults.tpl

+	<link rel="stylesheet" href="{$baseUrl}/styles/comments.css" type="text/css" />
+	<link rel="stylesheet" href="{$baseUrl}/plugins/generic/orcidProfile/css/orcidProfile.css" type="text/css" />
+
+	{foreach from=$stylesheets item=cssUrl}


Is orcidProfile.css declared twice? (also elsewhere)

defstat · 2017-06-25T20:45:09Z

templates/orcidProfileSearchResults.tpl

+			$("#orcidSearchResultsSubmit").click(function(event) {
+				event.preventDefault();
+				var profiles = {/literal}{$orcidSearchResults|@json_encode}{literal};                
+				var authorIndex = {/literal}{$authorIndex}{literal};                


The $authorIndex seems not to be filled after the user uses the searchResults pager [go from page1 to page2 for example]. That seems to result to a javascript error which "breaks" the javascript flow.

defstat · 2017-06-25T20:47:16Z

templates/orcidProfileSearchResults.tpl

+				var profileSelectedIndex = $("input[name=orcidProfile]:checked").val();
+				var profileSelected = profiles.theArray[profileSelectedIndex];
+
+				opener.document.getElementById("{/literal}{$orcidButtonId}{literal}").style.display = "none";;


extra ';' at the end of the line?

defstat · 2017-06-25T20:47:24Z

templates/orcidProfileSearchResults.tpl

+				var profileSelected = profiles.theArray[profileSelectedIndex];
+
+				opener.document.getElementById("{/literal}{$orcidButtonId}{literal}").style.display = "none";;
+				opener.document.getElementById("remove-orcid-button-" + authorIndex).style.display = "inline";;


extra ';' at the end of the line?

atarix83 · 2017-06-26T18:05:00Z

Hi @defstat thanks for reviewing.

I've made changes in base of your suggestions and fixed the issues.
I hope I've not forgotten anything

asmecher · 2017-07-25T00:14:15Z

@atarix83 and @defstat, part of merging this will also involve forward-porting it to OJS 3.x so it's not lost. @atarix83, do you have plans to upgrade to OJS 3.x?

atarix83 · 2017-07-25T11:00:14Z

@asmecher yes I would to upgrade to OJS 3.x but now I can't schedule an upgrade

defstat · 2017-07-25T11:02:49Z

@atarix83 I have done some work for OMP if that could be of help - https://github.com/defstat/orcidProfile/tree/hirmeos_orcid

asmecher · 2018-03-16T19:47:48Z

@defstat, this is an old PR but I see a few commits sneaking into it more recently -- are you keeping an eye on it?

defstat · 2018-03-16T20:01:31Z

@asmecher No but I can.

atarix83 added 7 commits March 23, 2017 18:39

New features added

a1e4fe3

Contributions added on comments

5ceaf05

show/hide buttons at init

9d6db49

Add profile information about affiliations and researcher Url.

8b85f16

Code reviewed.

Change README.md

061d8a8

Fix settings bug

0739157

Fix email field notice

821aa96

Adjust indentation

9822469

asmecher reviewed Apr 20, 2017

View reviewed changes

asmecher reviewed Apr 21, 2017

View reviewed changes

Adjust indentation

d97b6f4

asmecher reviewed Apr 26, 2017

View reviewed changes

Adjust indentation

90c1546

atarix83 changed the title ~~Ojs dev 2 4~~ ORCID plugin 2.4.8 May 15, 2017

defstat requested changes Jun 25, 2017

View reviewed changes

atarix83 and others added 19 commits June 26, 2017 15:16

Update emailTemplates.xml

2eb0064

Update locale.xml

c41f1f0

Update orcidProfileSearchForm.tpl

b8c8637

Update OrcidProfilePlugin.inc.php

cd5b26e

Update OrcidProfilePlugin.inc.php

25ef5c3

Update OrcidProfileSettingsForm.inc.php

8cd260e

Update OrcidProfilePlugin.inc.php

5ae3084

Update OrcidProfilePlugin.inc.php

393e2ce

Update README.md

d354b80

Update settingsForm.tpl

acce71d

Update OrcidHandler.inc.php

84403c1

Update OrcidHandler.inc.php

873e71a

Update OrcidHandler.inc.php

e299474

Update orcidProfile.tpl

68f40e5

Update orcidProfileSearch.tpl

b48814b

Update orcidProfileSearchResults.tpl

2c6bbb5

Fix issue with searchResults pager

e88a6c3

Update orcidProfileSearchResults.tpl

14529bb

Update orcidProfileSearchForm.tpl

04b3173

defstat approved these changes Jul 24, 2017

View reviewed changes

sourcedump added 3 commits February 23, 2018 15:16

Update to ORCID API v2.1

0c3d312

Indentation fix

547220f

ORCID url update

b18c342

dkikan mentioned this pull request Jan 2, 2023

PHP Fatal error: Uncaught Error: Call to a member function getId() on null #227

Closed



		</body>
		<description>This email template is used to collect the ORCID id's from co-authors.</description>

		@@ -1,11 +1,13 @@
		{**
		* plugins/generic/orcidProfile/orcidProfile.tpl

		@@ -0,0 +1,23 @@
		{**
		* plugins/generic/orcidProfile/orcidProfileSearch.tpl

		@@ -0,0 +1,162 @@
		{**
		* plugins/generic/orcidProfile/orcidProfileSearchResults.tpl

ORCID plugin 2.4.8 #14

Are you sure you want to change the base?

ORCID plugin 2.4.8 #14

Conversation

atarix83 commented Apr 7, 2017

asmecher commented Apr 7, 2017

atarix83 commented Apr 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asmecher commented Apr 21, 2017

atarix83 commented Apr 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asmecher commented Apr 26, 2017

ctgraham commented Apr 27, 2017

atarix83 commented Jun 14, 2017

asmecher commented Jun 14, 2017

defstat left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atarix83 commented Jun 26, 2017

asmecher commented Jul 25, 2017

atarix83 commented Jul 25, 2017

defstat commented Jul 25, 2017

asmecher commented Mar 16, 2018

defstat commented Mar 16, 2018

defstat left a comment •

edited

Loading