Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login process added to the code. #12

Open
wants to merge 1 commit into
base: ojs-dev-2_4
Choose a base branch
from

Conversation

defstat
Copy link

@defstat defstat commented Nov 21, 2016

Code added for orcid login process when within Journal context

@asmecher
Copy link
Member

@ctgraham, this PR is @defstat's take on login via ORCID. Mind taking a look to see how it compares with your sprint work?

@ctgraham
Copy link

The direction aligns well with our approach from the sprint. I'll note some specific comments via code review, but two things I would approach differently:

  • The user setting should be scoped by plugin name, e.g.: 'orcidProfile::authId`. Ideally this will also be constructed via a well-known constant so other external authentication plugins act similarly.
  • Authentication via lookup by email is a security risk. Our approach in the Sprint was to require an authentication OJS account to explicitly "link" the ORCID login. This is standard practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants