pkp/pkp-lib#9468 assign DOIs only to chapters that have a landing pag… #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozana
force-pushed
the
9468-3_4_0
branch
2 times, most recently
from
e92d6a1
to
37b9d86
Compare
ewhanson
reviewed
Aug 9, 2024
bozana
force-pushed
the
9468-3_4_0
branch
6 times, most recently
from
63c43c9
to
d180907
Compare
|
Hi Erik, could you please check the last two commits here? -- I adapted the test... |
touhidurabir
approved these changes
Aug 21, 2024
…e, and condsider chapter with DOI to have a landing page
ewhanson
approved these changes
Aug 21, 2024
|
To see now if submission sub items (chapters) have a DOI it needs to be considered if they have a landing page. I think we should not consider the chapters without landing page. For example: if a submission has one chapter without landing page, and if all other chapters have DOIs, the submission was listed when "Needs DOI" was used. Now, after this change, this example submission would not be listed, because all chapters that a DOI can be assigned to have already DOIs -- only the one without landing page, so that a DOI cannot be assigned to it, does not have it, and it should not be considered as 'Needs DOI'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s. pkp/pkp-lib#9468