Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+smallstep.com/certificates #7419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebst
Copy link
Contributor

@sebst sebst commented Sep 26, 2024

No description provided.

@jhheider
Copy link
Contributor

this is go and should be easy to build. was there some blocker that required vendoring?

@sebst
Copy link
Contributor Author

sebst commented Sep 26, 2024

this is go and should be easy to build. was there some blocker that required vendoring?

It's notarized and for such security relevant package it's probably more trustworthy to use the vendored packages

@jhheider
Copy link
Contributor

that's an interesting argument. we've built everything else in the stack in the open, with fully-transparent builds, and properly signed apple binaries, as do most other packagers. homebrew, for example, builds it here: https://github.com/Homebrew/homebrew-core/blob/f45ca9f767b050e0f9a16a155ba0d50baf49e865/Formula/s/step.rb#L32-L37. i'll think about this a little more.

@sebst
Copy link
Contributor Author

sebst commented Sep 26, 2024

that's an interesting argument. we've built everything else in the stack in the open, with fully-transparent builds, and properly signed apple binaries, as do most other packagers. homebrew, for example, builds it here: https://github.com/Homebrew/homebrew-core/blob/f45ca9f767b050e0f9a16a155ba0d50baf49e865/Formula/s/step.rb#L32-L37. i'll think about this a little more.

Let me know what you think. Should be relatively easy to build it from scratch

@sebst
Copy link
Contributor Author

sebst commented Sep 29, 2024

Any new thoughts?

@jhheider
Copy link
Contributor

yeah, i think we should probably maintain consistency. if someone is concerned, we can always provide a vendored version, or, more likely, they get the "official" binary themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants