Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix var quoting in cc #290

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix var quoting in cc #290

merged 1 commit into from
Jan 25, 2024

Conversation

jhheider
Copy link
Contributor

closes #289

@jhheider jhheider requested a review from mxcl January 25, 2024 15:55
@jhheider jhheider mentioned this pull request Jan 25, 2024
Closed
@mxcl
Copy link
Member

mxcl commented Jan 25, 2024

Just so I don't repeat this, what is the issue exactly? I went to the ticket but don’t get it.

@mxcl mxcl merged commit 60adba0 into main Jan 25, 2024
32 of 33 checks passed
@mxcl mxcl deleted the fix-var-quoting-in-cc branch January 25, 2024 17:44
@jhheider
Copy link
Contributor Author

cc: line 25: [: too many arguments

resulting from

'-DTHUMBNAILER_USAGE="Thumbnail images"'

on line

if [ $arg != -Werror ]; then

https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck highlights them all, if you want quick visibility

@mxcl
Copy link
Member

mxcl commented Jan 25, 2024

k, right. Always quote args that may contain quotes. Got it. I guess always quote for safety but I just don't like it.

@jhheider
Copy link
Contributor Author

and of such dislike are new shells born

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl Awaiting requested review from mxcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing shellchecks in cc
2 participants
@jhheider @mxcl