Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducible streams do not implement clojure.lang.Sequential #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glts
Copy link

@glts glts commented Dec 18, 2018

This change makes reducible streams implement clojure.lang.Sequential.

The reducible and seqable value returned by decode! does not implement clojure.lang.Sequential, even though it is sequential. I believe it is common and beneficial for such values to implement that marker interface, as it enables some interopability with consumers that rely on that marker (eg sequence specs).

Example: this program prints false now, true with the change applied.

echo 1 2 3 | clj -e "(use 'pjstadig.reducible-stream) (= [1 2 3] (decode-edn! *in*))"

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant