Fix wrong event state callback and re-subscribe method on event subscription. #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wrong callback on event: TSX_STATE when using dialog-event subscription - wrong method called to re-subscribe from timer callback
nanangizz
approved these changes
Dec 19, 2024
sauwming
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
For the title, better put something more descriptive rather than cite the PR number. This will help understand what the issue is, as well as make it easier to search in the future.
The related PR number can be put in the PR description (which you have already done).
trengginas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues related to #3754:
The callback
on_buddy_evsub_dlg_event_state()is called instead ofon_buddy_evsub_state().When a dialog-event subscription is sent, and responded with
496/Bad Event, the timer is setup for re-subcription and callpjsua_buddy_update_pres().