Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad address length check in pj_ioqueue_sendto() #3941

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix bad address length check in pj_ioqueue_sendto() #3941

merged 1 commit into from
Apr 29, 2024

Conversation

nanangizz
Copy link
Member

Fix issue #3938:

Assertion when checking address length in pj_ioqueue_sendto in ioqueue_common_abs.c of an IPv6 address. Looks like the PJ_ASSERT_RETURN(addrlen <= (int)sizeof(pj_sockaddr_in), PJ_EBUG) is old code that has not been updated to account for IPv6 addresses.

Thanks to @rickdialpad for the detailed report and the proposed patch.

PS: I don't think verifying the address family is necessary here as the check seems to concern about the storage capacity only. Btw, also updated the storage type (write_operation.rmt_addr) to pj_sockaddr.

@nanangizz nanangizz added this to the release-2.15 milestone Apr 29, 2024
@nanangizz nanangizz linked an issue Apr 29, 2024 that may be closed by this pull request
Crash in ioqueue_common_abs.c pj_ioqueue_sendto when checking IPv6 address length #3938
Closed
sauwming
sauwming approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@sauwming sauwming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, but doesn't seem related.

@nanangizz
Copy link
Member Author

CI failed, but doesn't seem related.

PJMEDIA_SRTP_HAS_DTLS set to 1 in config_site_test.h, while configure cannot detect OpenSSL, so the error is quite as expected.

Not sure why other previous CI sessions didn't fail here, perhaps OpenSSL were available most of the time (not always)?

@nanangizz nanangizz merged commit f38d781 into master Apr 29, 2024
29 of 36 checks passed
@nanangizz nanangizz deleted the ioqueue-sendto-ipv6 branch April 29, 2024 08:01
dshamaev-intermedia added a commit to intermedia-net/pjproject that referenced this pull request Jun 12, 2024
@github-actions @naf419
@goodicus @amubiera @xhit @sauwming @nanangizz @dshamaev-intermedia @pespin @trengginas @peldszus
Automated Pull Request (#86)
e9b9e72 
* Add missing openssl SECLEVEL=0 support (pjsip#3890)

Previous SECLEVEL support allowed for levels 1-5.
However, openssl defines levels 0-5. [1]

Recent openssl versions (3.0+) have moved previous
popular ciphers/key lengths (i.e. RSA1024withSHA1)
into level 0, so it is now a reasonable choice to use.

Add support for level 0.

[1] https://www.openssl.org/docs/man3.2/man3/SSL_CTX_set_security_level.html

* Enable Late Offer Answer Mode (LOAM) feature in the pjsua (pjsip#3869)

* Fix warnings for 32-bit compiler and misc fixes. (pjsip#3896)

* Add some missing unlocks (pjsip#3893)

* Prevent race condition in DTLS media stop (pjsip#3901)

* Fix data race reported by ThreadSanitizer in caching pool (pjsip#3897)

* Fixed Metal renderer memory leak (pjsip#3909)

* Fixed DTLS clock stoppage race (pjsip#3905)

* Improve IP address change IPv4 <-> IPv6 (pjsip#3910)

* pjsua_acc: Fix warnings for comparison between ‘pjsua_nat64_opt’ and ‘enum pjsua_ipv6_use’ (pjsip#3915)

* Fix to ext_fmts accessed out of stack scope. (pjsip#3916)

* Add check in siprtp sample app for inactive audio media (pjsip#3927)

* Add function to initialize MediaFormat audio & video (pjsip#3925)

* Fixed incorrect SDP buffer length calculation (pjsip#3924)

* Support Push Notification in iOS sample app (pjsip#3913)

* Fixed PJSUA2 API to get/set Opus config (pjsip#3935)

* Fix bad address length check in pj_ioqueue_sendto(). (pjsip#3941)

* Fix warning of uninitialized value in fuzz-crypto (pjsip#3946)

* Print log on successful send (pjsip#3942)

* Fixed CI Mac build failure (pjsip#3947)

* Update Android JNI audio dev to use 16bit PCM only (pjsip#3945)

* Add TLS/SSL backend: Windows Schannel (pjsip#3867)

* pjsip_find_msg: Log warning if Content-Length field not found (pjsip#3960)

* Fix audiodev index (pjsip#3962)

* Fix assertion on call hangup from DTMF callback (pjsip#3970)

* Fix yaml error in github feature template (pjsip#3972)

* Fix version string in Python setup (pjsip#3976)

* Prevent pjmedia_codec_param.info.enc_ptime_denum division by zero in stream (pjsip#3975)

---------

Co-authored-by: naf <[email protected]>
Co-authored-by: Goodicus <[email protected]>
Co-authored-by: Amilcar Ubiera <[email protected]>
Co-authored-by: Santiago De la Cruz <[email protected]>
Co-authored-by: sauwming <[email protected]>
Co-authored-by: Nanang Izzuddin <[email protected]>
Co-authored-by: dshamaev-intermedia <[email protected]>
Co-authored-by: CI Bot <[email protected]>
Co-authored-by: Pau Espin Pedrol <[email protected]>
Co-authored-by: Riza Sulistyo <[email protected]>
Co-authored-by: Andreas Peldszus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauwming sauwming sauwming approved these changes

@trengginas trengginas trengginas approved these changes

Assignees
No one assigned
Labels
component: pjlib type: bug
Projects
None yet
Milestone
release-2.15
Development

Successfully merging this pull request may close these issues.

Crash in ioqueue_common_abs.c pj_ioqueue_sendto when checking IPv6 address length
3 participants
@nanangizz @trengginas @sauwming