Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion in restarting listeners in IP change scenario #3872

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

nanangizz
Copy link
Member

@nanangizz nanangizz commented Feb 27, 2024

Reported that in some rare case, assertion happens with call stack:

Thread 0 Crashed:
0   libsystem_kernel.dylib               0x000000018c14a0dc __pthread_kill + 8
1   libsystem_c.dylib                    0x000000018c08da40 abort + 176
2   libsystem_c.dylib                    0x000000018c08cd30 __assert_rtn + 280
3   libphone.0.dylib                     0x0000000103ff5f74 pj_sockaddr_get_port (sock_common.c:367)
4   libphone.0.dylib                     0x0000000104152cb4 restart_listener (pjsua_core.c:3841)
5   libphone.0.dylib                     0x0000000104152b30 pjsua_handle_ip_change (pjsua_core.c:3998)

Unfortunately finding the cause of the issue is not so easy with the available info. This PR attempts to avoid the assertion (not really fix the cause).

Thanks to Oliver Epper for the report.

PS: this PR also contain a fix of a minor issue in shutting down transport in IP change (local var shadowing parameter param).

@nanangizz nanangizz merged commit 7d2248f into master Mar 6, 2024
35 checks passed
@nanangizz nanangizz deleted the assert-on-restart-listener branch March 6, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants