Add an option to disable Message Composition Indication feature (MCI) #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(RFC-3994). The feature is always ON currently.
The PR switches off the feature by default and adds an option in a
configuration file ("--set-mci") to enable it.
|
Usually we don't change default behaviors except for a strong reason, e.g: security issues. So what if the new option is to disable the MCI instead? |
|
@nanangizz I got your point and will rework the implementation. |
Message Composition Information (RFC-3994). The option name is "--no-mci".
|
Add an option to disable the default pjsua behaviour to not send Message Composition Information (RFC-3994). |
goodicus
changed the title
nanangizz
approved these changes
Feb 22, 2024
sauwming
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Message Composition Indication feature (RFC-3994) is always enabled currently. And it leads to sending massive messages while typing.
The PR switches off the feature by default and adds an option to a configuration file to enable the feature