Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecation warnings on Mac and iOS #3837

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fixed deprecation warnings on Mac and iOS #3837

merged 2 commits into from
Jan 22, 2024

Conversation

sauwming
Copy link
Member

Increase default minimum iOS version to 11 as XCode 14 doesn't support deployment to releases older than iOS 11 (note that latest XCode is now XCode 15).
https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes
Building for deployment to OS releases older than macOS 10.13, iOS 11, tvOS 11, and watchOS 4 is no longer supported. (92834476)

Also fixed various deprecation warnings on Mac and iOS:

../src/pjmedia-audiodev/coreaudio_dev.m:557:25: warning: 'kAudioObjectPropertyElementMaster' is
 deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
        addr.mElement = kAudioObjectPropertyElementMaster;
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                        kAudioObjectPropertyElementMain
../src/pjmedia-videodev/darwin_dev.m:329:21: warning: 'AVCaptureDeviceTypeBuiltInDuoCamera' is
 deprecated: first deprecated in iOS 10.2 - Use AVCaptureDeviceTypeBuiltInDualCamera instead. [-Wdeprecated-declarations]
                  , AVCaptureDeviceTypeBuiltInDuoCamera
../src/pjmedia-videodev/darwin_dev.m:342:41: warning: 'devices' is deprecated: first deprecated in
 iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead. [-Wdeprecated-declarations]
            dev_list = [AVCaptureDevice devices];
../src/pj/activesock.c:155:37: warning: 'kCFStreamNetworkServiceTypeVoIP' is deprecated: first 
deprecated in iOS 9.0 - use PushKit for VoIP control purposes [-Wdeprecated-declarations]
                                    kCFStreamNetworkServiceTypeVoIP)

@sauwming sauwming self-assigned this Jan 22, 2024
@sauwming sauwming added this to the release-2.15 milestone Jan 22, 2024
@sauwming
Copy link
Member Author

More deprecation after Mac OS Sonoma update (Mac OS 14.0):

../src/pjmedia-videodev/darwin_dev.m:326:21: warning: 'AVCaptureDeviceTypeExternalUnknown' is deprecated:
first deprecated in macOS 14.0 [-Wdeprecated-declarations]
../src/pjmedia-videodev/darwin_dev.m:1271:19: warning: 'AVCaptureVideoOrientation' is deprecated:
first deprecated in macOS 14.0 - Use AVCaptureDeviceRotationCoordinator instead [-Wdeprecated-declarations]
../src/pjmedia-videodev/darwin_dev.m:1289:24: warning: 'videoOrientation' is deprecated:
first deprecated in macOS 14.0 - Use -videoRotationAngle instead [-Wdeprecated-declarations]

@sauwming sauwming merged commit d762276 into master Jan 22, 2024
35 checks passed
@sauwming sauwming deleted the deprecated branch January 22, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants