Fixed SDP media transport protocol info parsing #3802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #3800.
Summary of the report:
In
pjmedia_sdp_transport_get_proto()
:rest.slen
will be set to -1 if delimiter/
is not found within the string, such as if the transport is plainudp
.This causes the subsequent check within the function to not work properly:
Thank you to @miguelpenades for the report and the patch.