Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix answering a re-INVITE #3770

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Fix answering a re-INVITE #3770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aa2517
Fix answering a re-INVITE
wosrediinanatour Nov 7, 2023
7886a0d
Update pjsua_call.c
sauwming Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pjsip/src/pjsua-lib/pjsua_call.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2744,8 +2744,8 @@ PJ_DEF(pj_status_t) pjsua_call_answer2(pjsua_call_id call_id,
if (status != PJ_SUCCESS)
goto on_return;

if (call->inv->role == PJSIP_ROLE_UAC ||
!call->inv->invite_tsx ||
if (!call->inv->invite_tsx ||
call->inv->invite_tsx->role != PJSIP_ROLE_UAC ||
call->inv->invite_tsx->state >= PJSIP_TSX_STATE_COMPLETED)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of evaluating invite session role (call->inv->role), perhaps the original patch should evaluate invite transaction role call->inv->invite_tsx->role, this way it will work for inital & subsequent invite, so the check conditions should have been:

if (!call->inv->invite_tsx ||
     call->inv->invite_tsx->role != PJSIP_ROLE_UAC ||
     call->inv->invite_tsx->state >= PJSIP_TSX_STATE_COMPLETED)

PJ_LOG(3,(THIS_FILE, "Unable to answer call (no incoming INVITE or "
Expand Down
Loading