Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premature destroy in NAT detection #3747

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Premature destroy in NAT detection #3747

merged 1 commit into from
Oct 25, 2023

Conversation

nanangizz
Copy link
Member

Reported crash in NAT detection with call stack trace like:

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)

0   grp_lock_acquire + 68 (lock.c:297)
1   pj_grp_lock_acquire + 24 (lock.c:486)
2   on_sess_timer + 160 (nat_detect.c:915)
3   pj_timer_heap_poll + 616 (timer.c:912)

A possible cause is a race condition between timer and socket which can cause NAT detect session to be prematurely destroyed.

@nanangizz nanangizz merged commit 5651d24 into master Oct 25, 2023
34 checks passed
@nanangizz nanangizz deleted the natd-race branch October 25, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants