Fixed bug in SRTP ROC checking when using ICE #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanangizz
reviewed
Oct 9, 2023
pjsip/src/pjsua-lib/pjsua_media.c
Outdated
| const pjmedia_sdp_media *remote_sdp) | ||
| const pjmedia_sdp_media *local_m, | ||
| const pjmedia_sdp_session *rem_sdp, | ||
| const pjmedia_sdp_media *rem_m) |
There was a problem hiding this comment.
minor:
- as there are
rem_sdp&med_idxparams already, perhapsrem_mis not necessary? - also, what if the same mechanism (check media level first, then check session level) is also applied for the local SDP, for example to handle the case when the SDP is generated/modified by the app?
nanangizz
approved these changes
Oct 9, 2023
trengginas
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in SRTP ROC checking when remote specifies ICE ufrag in the session descriptor, instead of within the media.