Add error handling to IconEx::GetImageSource

Bloxstrap/Extensions/IconEx.cs

@@ -10,9 +10,22 @@ public static class IconEx
 
  public static ImageSource GetImageSource(this Icon icon)
  {
- using MemoryStream stream = new();
- icon.Save(stream);
- return BitmapFrame.Create(stream, BitmapCreateOptions.None, BitmapCacheOption.OnLoad);
+ const string LOG_IDENT = "IconEx::GetImageSource";
+
+ try
+ {
+ using MemoryStream stream = new();
+ icon.Save(stream);
+ return BitmapFrame.Create(stream, BitmapCreateOptions.None, BitmapCacheOption.OnLoad);
+ }
+ catch (Exception ex)
+ {
+ App.Logger.WriteLine(LOG_IDENT, "Failed to get ImageSource");
+ App.Logger.WriteException(LOG_IDENT, ex);
+
+ // return fallback image
+ return Utilities.GetEmptyBitmap();
+ }
  }
  }
 }

Bloxstrap/Utilities.cs

@@ -1,4 +1,6 @@
 using System.ComponentModel;
+using System.Windows.Media.Imaging;
+using System.Windows.Media;
 
 namespace Bloxstrap
 {
@@ -81,5 +83,17 @@ public static Process[] GetProcessesSafe()
  return Array.Empty<Process>(); // can we retry?
  }
  }
+
+ private static BitmapSource? _emptyBitmap;
+ public static BitmapSource GetEmptyBitmap()
+ {
+ return _emptyBitmap ??= CreateEmptyBitmap();
+ }
+
+ // https://stackoverflow.com/a/50316845
+ public static BitmapSource CreateEmptyBitmap()
+ {
+ return BitmapSource.Create(1, 1, 1, 1, PixelFormats.BlackWhite, null, new byte[] { 0 }, 1);
+ }
  }
 }