Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast flag editor showing an error when trying to add a fast flag with _PlaceFilter or _DataCenterFilter #2355

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

srthMD
Copy link
Contributor

@srthMD srthMD commented Jul 13, 2024

Before, trying to add a fast flag with a place filter like the one below would present an error saying the value was
invalid depending on the required type.

{
    "FFlagSoundsUsePhysicalVelocity_PlaceFilter": "true;292439477"
}

image

After, importing the same json now will successfully import the fast flag and the changes will apply.
image

And if the place filter is invalid, like a trailing semicolon, it will error
image

Closes #2348

(sorry if theres any issues, this is my first time making a pr)

@pizzaboxer
Copy link
Owner

Validation code looks good, actually is more than what I would've done.

@pizzaboxer pizzaboxer merged commit 6bc1415 into pizzaboxer:main Jul 29, 2024
3 checks passed
@srthMD srthMD deleted the place-filter branch July 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PlaceFilter being blocked due to fflag being DFFlag
3 participants