Skip to content

Commit

Permalink
Remove flag preset for graphics quality slider
Browse files Browse the repository at this point in the history
RIP
  • Loading branch information
pizzaboxer committed Sep 9, 2024
1 parent 356155c commit 7a0f50b
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 38 deletions.
2 changes: 0 additions & 2 deletions Bloxstrap/FastFlagManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public class FastFlagManager : JsonManager<Dictionary<string, object>>
{ "UI.FlagState", "FStringDebugShowFlagState" },
#endif

{ "UI.Menu.GraphicsSlider", "FFlagFixGraphicsQuality" },
{ "UI.FullscreenTitlebarDelay", "FIntFullscreenTitleBarTriggerDelayMillis" },

{ "UI.Menu.Style.V2Rollout", "FIntNewInGameMenuPercentRollout3" },
Expand All @@ -62,7 +61,6 @@ public class FastFlagManager : JsonManager<Dictionary<string, object>>
{ "UI.Menu.Style.ABTest.3", "FFlagEnableInGameMenuChromeABTest3" }
};

// only one missing here is Metal because lol
public static IReadOnlyDictionary<RenderingMode, string> RenderingModes => new Dictionary<RenderingMode, string>
{
{ RenderingMode.Default, "None" },
Expand Down
2 changes: 2 additions & 0 deletions Bloxstrap/Installer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,8 @@ public static void HandleUpgrade()

App.FastFlags.SetValue("FFlagDisableNewIGMinDUA", null);
}

App.FastFlags.SetValue("FFlagFixGraphicsQuality", null);
}

App.Settings.Save();
Expand Down
18 changes: 0 additions & 18 deletions Bloxstrap/Resources/Strings.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions Bloxstrap/Resources/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -637,12 +637,6 @@ Do NOT use this to import large "flag lists" made by other people that promise t
<value>Learn more about Fast Flags, what these presets do, and how to use them.</value>
<comment>Title is Common.Help</comment>
</data>
<data name="Menu.FastFlags.Presets.AltGraphicsSelector.Description" xml:space="preserve">
<value>Allows you to configure 21 different quality levels instead of 10.</value>
</data>
<data name="Menu.FastFlags.Presets.AltGraphicsSelector.Title" xml:space="preserve">
<value>Use advanced graphics quality selector</value>
</data>
<data name="Menu.FastFlags.Presets.D3DExclusiveFullscreenInfo" xml:space="preserve">
<value>Direct3D [exclusive fullscreen]({0}) using Alt+Enter is enabled by default.</value>
</data>
Expand Down
6 changes: 0 additions & 6 deletions Bloxstrap/UI/Elements/Settings/Pages/FastFlagsPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,6 @@
</ComboBox>
</controls:OptionControl>

<controls:OptionControl
Header="{x:Static resources:Strings.Menu_FastFlags_Presets_AltGraphicsSelector_Title}"
Description="{x:Static resources:Strings.Menu_FastFlags_Presets_AltGraphicsSelector_Description}">
<ui:ToggleSwitch IsChecked="{Binding AlternateGraphicsSelectorEnabled, Mode=TwoWay}" />
</controls:OptionControl>

<ui:CardAction Margin="0,24,0,0" Icon="EditSettings24" Command="{Binding OpenFastFlagEditorCommand}">
<StackPanel>
<TextBlock FontSize="14" Text="{x:Static resources:Strings.Menu_FastFlagEditor_Title}" />
Expand Down
6 changes: 0 additions & 6 deletions Bloxstrap/UI/ViewModels/Settings/FastFlagsViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,6 @@ public bool FixDisplayScaling
set => App.FastFlags.SetPreset("Rendering.DisableScaling", value ? "True" : null);
}

public bool AlternateGraphicsSelectorEnabled
{
get => App.FastFlags.GetPreset("UI.Menu.GraphicsSlider") == "True";
set => App.FastFlags.SetPreset("UI.Menu.GraphicsSlider", value ? "True" : null);
}

public IReadOnlyDictionary<InGameMenuVersion, Dictionary<string, string?>> IGMenuVersions => FastFlagManager.IGMenuVersions;

public InGameMenuVersion SelectedIGMenuVersion
Expand Down

1 comment on commit 7a0f50b

@Vlad55432
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

Please sign in to comment.