Reduce redundant logs when setting flags

pizzaboxer · Jul 24, 2023 · 6547118 · 6547118
1 parent d186126
commit 6547118
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/Bloxstrap/FastFlagManager.cs b/Bloxstrap/FastFlagManager.cs
@@ -110,13 +110,19 @@ public void SetValue(string key, object? value)
  {
  if (value is null)
  {
+ if (Prop.ContainsKey(key))
+ App.Logger.WriteLine($"[FastFlagManager::SetValue] Deletion of '{key}' is pending");
+
  Prop.Remove(key);
- App.Logger.WriteLine($"[FastFlagManager::SetValue] Deletion of '{key}' is pending");
  }
  else
  {
+ if (Prop.ContainsKey(key))
+ App.Logger.WriteLine($"[FastFlagManager::SetValue] Setting of '{key}' from '{Prop[key]}' to '{value}' is pending");
+ else
+ App.Logger.WriteLine($"[FastFlagManager::SetValue] Setting of '{key}' to '{value}' is pending");
+
  Prop[key] = value.ToString()!;
- App.Logger.WriteLine($"[FastFlagManager::SetValue] Setting of '{key}' to '{value}' is pending");
  }
  }
 
@@ -157,13 +163,13 @@ public void SetPresetEnum(string prefix, string target, object? value)
 
  public string GetPresetEnum(IReadOnlyDictionary<string, string> mapping, string prefix, string value)
  {
- foreach (var mode in mapping)
+ foreach (var pair in mapping)
  {
- if (mode.Key == mapping.First().Key)
+ if (pair.Value == "None")
  continue;
 
- if (App.FastFlags.GetPreset($"{prefix}.{mode.Value}") == value)
- return mode.Key;
+ if (GetPreset($"{prefix}.{pair.Value}") == value)
+ return pair.Key;
  }
 
  return mapping.First().Key;