Merge pull request #2945 from pizzaboxer/bugfix/you-forgot-to-use-str…

…ings-resx Add string to translations
pizzaboxer · Sep 21, 2024 · 5977b1b · 5977b1b
2 parents 6e0d24e + c6a6ab2
commit 5977b1b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/Bloxstrap/Resources/Strings.Designer.cs b/Bloxstrap/Resources/Strings.Designer.cs
diff --git a/Bloxstrap/Resources/Strings.resx b/Bloxstrap/Resources/Strings.resx
@@ -1192,6 +1192,9 @@ Please manually delete Bloxstrap.exe from the install location or try restarting
  <data name="Common.RobloxNotInstalled" xml:space="preserve">
  <value>Roblox has not yet been installed. Please launch Roblox using Bloxstrap at least once before trying to use this option.</value>
  </data>
+ <data name="Installer.ShouldCancel" xml:space="preserve">
+ <value>Are you sure you want to cancel the installation?</value>
+ </data>
  <data name="Bootstrapper.JsonManagerSaveFailed" xml:space="preserve">
  <value>Failed to save {0}: {1}</value>
  </data>

diff --git a/Bloxstrap/UI/Elements/Installer/MainWindow.xaml.cs b/Bloxstrap/UI/Elements/Installer/MainWindow.xaml.cs
@@ -9,6 +9,7 @@
 using Bloxstrap.UI.Elements.Base;
 using System.Windows.Media.Animation;
 using System.Reflection.Metadata.Ecma335;
+using Bloxstrap.Resources;
 
 namespace Bloxstrap.UI.Elements.Installer
 {
@@ -102,7 +103,7 @@ void MainWindow_Closing(object? sender, CancelEventArgs e)
  if (Finished)
  return;
 
- var result = Frontend.ShowMessageBox("Are you sure you want to cancel the installation?", MessageBoxImage.Warning, MessageBoxButton.YesNo);
+ var result = Frontend.ShowMessageBox(Strings.Installer_ShouldCancel, MessageBoxImage.Warning, MessageBoxButton.YesNo);
 
  if (result != MessageBoxResult.Yes)
  e.Cancel = true;