Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for data url loading #506

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ABrozovic
Copy link

Enables users to pass dataURLs directly in the spineAtlasFile and image Metadata fields. This enhancement expands the flexibility and convenience of working with spine animations by allowing dataURLs as valid inputs.

@miltoncandelero
Copy link
Contributor

You have some things mixed 😬

the atlas file (.atlas) should be text/plain.

application/octet-stream should be for binary skeleton files .skel

@ABrozovic
Copy link
Author

I'm using FileReader's readAsDataURL method which assigns the MIME type "application/octet-stream" to the resulting data URL when reading a plain text file.
But you are correct, const validAtlasMIME = ['application/octet-stream', 'text/plain'];. would be a more accurate evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants