Fix cloud proxy entrypoint by avoiding modifying a RO directory (Configmap mount directory) #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entrypoint writing to RO mount Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
changed the title
vihangm
approved these changes
Sep 18, 2024
ddelnano
deleted the
ddelnano/fix-cloud-proxy-ro-configmap-mount-issue
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…igmap mount directory) (pixie-io#2027) Summary: Fix cloud proxy entrypoint by avoiding modifying a RO directory (Configmap mount directory) This bug was introduced between 0a44b36 and c3e0fba on pixie-io#2018 when the individual file mounts were changed to a directory mount. Deploying the cloud proxy from main results in the following error: ``` $ kubectl -n plc logs cloud-proxy-5df85487bf-hrglr Defaulted container "cloud-proxy-server" out of: cloud-proxy-server, envoy /scripts/entrypoint.sh: line 20: can't create /usr/local/openresty/nginx/conf/nginx.conf: Read-only file system ``` When I originally tested the final change, I must have only looked at the resulting directory and missed that the pod was crashing. This issue was detected during the 0.1.8 cloud prerelease testing. Relevant Issues: pixie-io#2017 pixie-io#2013 Type of change: /kind bugfix Test Plan: Verified that the cloud proxy image starts up successfully Signed-off-by: Dom Del Nano <[email protected]> GitOrigin-RevId: 1f96cff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix cloud proxy entrypoint by avoiding modifying a RO directory (Configmap mount directory)
This bug was introduced between 0a44b36 and c3e0fba on #2018 when the individual file mounts were changed to a directory mount. Deploying the cloud proxy from main results in the following error:
When I originally tested the final change, I must have only looked at the resulting directory and missed that the pod was crashing. This issue was detected during the 0.1.8 cloud prerelease testing.
Relevant Issues: #2017 #2013
Type of change: /kind bugfix
Test Plan: Verified that the cloud proxy image starts up successfully