Fix bug where cli manifests with AT_DARWIN_ARM64 ArtifactTypes fail to parse
#2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o parse Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
vihangm
approved these changes
Sep 4, 2024
…by gazelle Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
|
After updating the protos, I ran into the following gazelle error: I saw that gazelle recommends against building the Here is the difference between the target files before and after the failed build and the successful one. |
Signed-off-by: Dom Del Nano <[email protected]>
vihangm
approved these changes
Sep 4, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
… to parse (pixie-io#2005) Summary: Fix bug where cli manifests with `AT_DARWIN_ARM64` ArtifactTypes fail to parse This was an error I ran into when testing pixie-io#1997. You can see the failure output from the [following build](https://github.com/pixie-io/pixie/actions/runs/10705210930/job/29681122220?pr=1997) (also copied below). ``` INFO: Running command line: bazel-bin/src/utils/artifacts/manifest_updater/manifest_updater_/manifest_updater '--manifest_updates=/__w/pixie/pixie/manifest_updates.json' '--manifest_path=/__w/pixie/pixie/gh-pages/artifacts/manifest.json' time="2024-09-04T16:17:53Z" level=fatal msg="failed to read manifest updates" error="unknown value \"AT_DARWIN_ARM64\" for enum px.versions.ArtifactType" ``` Relevant Issues: pixie-io#1993 Type of change: /kind bugfix Test Plan: Built the manifest_updater binary and verified it no longer fails with a parse error ``` $ ./manifest_updater --manifest_updates manifest_updates.json --manifest_path=manifest.json $ ``` --------- Signed-off-by: Dom Del Nano <[email protected]> GitOrigin-RevId: afffb8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix bug where cli manifests with
AT_DARWIN_ARM64ArtifactTypes fail to parseThis was an error I ran into when testing #1997. You can see the failure output from the following build (also copied below).
Relevant Issues: #1993
Type of change: /kind bugfix
Test Plan: Built the manifest_updater binary and verified it no longer fails with a parse error