Replace hand crafted query interpolation with sqlx parameter binding #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lx parameter binding Signed-off-by: Dom Del Nano <[email protected]> (cherry picked from commit 3457ad3fe28ba58edbc125677f60da84b6cf545b)
…nding Signed-off-by: Dom Del Nano <[email protected]> (cherry picked from commit 355f13ae055d8ed4ff9b96008cc77116c9a4333f)
vihangm
approved these changes
Jun 24, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…ixie-io#1952) Summary: Replace hand crafted query interpolation with sqlx parameter binding Relevant Issues: N/A Type of change: /kind bug Test Plan: Verified the following after skaffold'ing this change - [x] Verified that the "Data Retention Scripts" page loads to test the cron script query - [x] Verified that `/admin/clusters` page loads to test the vzmgr query GitOrigin-RevId: 86c40e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replace hand crafted query interpolation with sqlx parameter binding
Relevant Issues: N/A
Type of change: /kind bug
Test Plan: Verified the following after skaffold'ing this change
/admin/clusterspage loads to test the vzmgr query