Convert users.profile_picture column to TEXT type
#1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <[email protected]> (cherry picked from commit bc26d6834075391844569821d5e1684eb6faf5a5)
|
I think we should consider just migrating it to type |
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
changed the title
users.profile_picture columnusers.profile_picture column to TEXT type
vihangm
approved these changes
Jun 24, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
GitOrigin-RevId: 6cae152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Convert
users.profile_picturecolumn toTEXTtypeMy Google account's most recent profile picture's URL contains 1032 characters (link here). This is larger than the 1024 VARCHAR for the
users.profile_picturecolumen. This change converts the column to use aTEXTtype to avoid issues with long URLs.Relevant Issues: N/A
Type of change: /kind bug
Test Plan: Recently deployed cloud no longer fails at login