[record & replay] Move callback cookie into perf buffer spec. #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2023 12:22
…) record & replay can depend on them. Signed-off-by: Pete Stevenson <[email protected]>
Signed-off-by: Pete Stevenson <[email protected]>
Signed-off-by: Pete Stevenson <[email protected]>
ddelnano
approved these changes
Aug 7, 2023
vihangm
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To support record & replay, we move the callback cookie into the perf buffer spec. Previously, we plumbed it through as a separate argument. Moving the callback cookie into the perf buffer spec. will allow us to insert a different callback and save the original callback, i.e. to interpose a recorder for recording of perf buffer events.
Relevant Issues: #1163
Type of change: /kind feature
Test Plan: Fully covered by existing tests.