Allow VizierID to be used to find the Vizier's org #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zier's org to set feature flags. Signed-off-by: Kartik Pattaswamy <[email protected]>
kpattaswamy
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
ddelnano
reviewed
Aug 3, 2023
kpattaswamy
commented
Aug 4, 2023
aimichelle
reviewed
Aug 4, 2023
Signed-off-by: Kartik Pattaswamy <[email protected]>
… to create a vzmgrClient Signed-off-by: Kartik Pattaswamy <[email protected]>
kpattaswamy
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
aimichelle
reviewed
Aug 8, 2023
Signed-off-by: Kartik Pattaswamy <[email protected]>
kpattaswamy
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
vihangm
approved these changes
Aug 9, 2023
Signed-off-by: Kartik Pattaswamy <[email protected]>
kpattaswamy
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
vihangm
approved these changes
Aug 9, 2023
kpattaswamy
added a commit
to kpattaswamy/pixie
that referenced
this pull request
Aug 11, 2023
…#1650)" This reverts commit 1c328aa. Signed-off-by: Kartik Pattaswamy <[email protected]>
kpattaswamy
added a commit
to kpattaswamy/pixie
that referenced
this pull request
Aug 11, 2023
…#1650)" This reverts commit 1c328aa. Signed-off-by: Kartik Pattaswamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR allows the VizierID to be used when getting the org as opposed to only relying on the DeployKey when adding feature flags.
Relevant Issues: #1632
Type of change: /kind bug
Test Plan: Another PR needs to come in on the operator side to retrieve/send the VizierID to the cloud. Getting this PR in on the cloud side will simplify the process of testing the integration between the two later.