[operator] Check for CSIDriver matching StorageClass provisioner #1616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously the operator checked for a specific
ebs-csi-controller
in thekube-system
namespace on EKS clusters to determine whether PVCs are supported. This was a bit fragile and led to issues like #1577. Instead, this PR changes the operator to check that the provisioner of the default storage class has a corresponding CSIDriver. This avoids the need to look for a specific deployment, and should allow people to use non-etcd pixie with custom PVC controller setups. For now to avoid to much change, we only do this check for the EKS clusters we used to check for the deployment, but in theory we could do this check for all clusters.Relevant Issues: Fixes #1577
Type of change: /kind bug
Test Plan: Tested that the new operator deployed to an EKS cluster with the default EKS ebs csi controller in
kube-system
doesn't cause an etcd deploy of pixie. Tested that the new operator deployed to an EKS cluster withaws-ebs-csi-controller
helm chart deployed to a custom namespace now doesn't use etcd (i.e. tested the bug in #1577). Also tested that a deploy to EKS without an csi controller deployed will still use an etcd version of pixie.Changelog Message: