Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] Check for CSIDriver matching StorageClass provisioner #1616

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

JamesMBartlett
Copy link
Member

@JamesMBartlett JamesMBartlett commented Jul 12, 2023

Summary: Previously the operator checked for a specific ebs-csi-controller in the kube-system namespace on EKS clusters to determine whether PVCs are supported. This was a bit fragile and led to issues like #1577. Instead, this PR changes the operator to check that the provisioner of the default storage class has a corresponding CSIDriver. This avoids the need to look for a specific deployment, and should allow people to use non-etcd pixie with custom PVC controller setups. For now to avoid to much change, we only do this check for the EKS clusters we used to check for the deployment, but in theory we could do this check for all clusters.

Relevant Issues: Fixes #1577

Type of change: /kind bug

Test Plan: Tested that the new operator deployed to an EKS cluster with the default EKS ebs csi controller in kube-system doesn't cause an etcd deploy of pixie. Tested that the new operator deployed to an EKS cluster with aws-ebs-csi-controller helm chart deployed to a custom namespace now doesn't use etcd (i.e. tested the bug in #1577). Also tested that a deploy to EKS without an csi controller deployed will still use an etcd version of pixie.

Changelog Message:

Fixes bug in the operator where some EKS clusters were being forced into an etcd version of pixie despite having support for PVCs.

@JamesMBartlett JamesMBartlett requested a review from a team as a code owner July 12, 2023 22:10
@JamesMBartlett JamesMBartlett merged commit 6e0c199 into pixie-io:main Jul 12, 2023
20 checks passed
@JamesMBartlett JamesMBartlett deleted the fix_csi_driver_check branch July 12, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vizier operator using etcd despite useEtcdOperator: false flag
2 participants