Skip to content

Commit

Permalink
Refactor vendor specific signup message to configurables (#1962)
Browse files Browse the repository at this point in the history
Summary: Refactor vendor specific signup message to configurables

Relevant Issues: N/A

Type of change: /kind clenaup

Test Plan:  Verified `/auth/signup`'s text is displayed as it was before

Signed-off-by: Dom Del Nano <[email protected]>
  • Loading branch information
ddelnano authored Jul 4, 2024
1 parent e0aa3e2 commit 87eb8af
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
20 changes: 20 additions & 0 deletions src/ui/src/configurables/base/signup.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/*
* Copyright 2018- The Pixie Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* SPDX-License-Identifier: Apache-2.0
*/

export const signupMessage = `Pixie Community is Free Forever.
No Credit Card Needed.`;
4 changes: 2 additions & 2 deletions src/ui/src/pages/auth/signup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { createStyles, makeStyles } from '@mui/styles';

import { AuthBox, SignupMarcom } from 'app/components';
import pixieAnalytics from 'app/utils/analytics';
import { signupMessage } from 'configurable/signup';

import { BasePage } from './base';
import { GetOAuthProvider } from './utils';
Expand Down Expand Up @@ -64,8 +65,7 @@ export const SignupPage = React.memo(() => {
toggleURL={`/auth/login${window.location.search}`}
title='Get Started'
// Need to encapsulate so that newline is properly escaped.
body={`Pixie Community is Free Forever.
No Credit Card Needed.`}
body={signupMessage}
buttonCaption='Already have an account?'
buttonText='Login'
showTOSDisclaimer
Expand Down

0 comments on commit 87eb8af

Please sign in to comment.