Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: framer-motion bundle reduction #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: framer-motion bundle reduction #111

wants to merge 2 commits into from

Conversation

Den-Bratchikov
Copy link
Contributor

@Den-Bratchikov Den-Bratchikov commented Dec 9, 2022 •
edited
Loading

This pull request adds update which reduces framer-motion bundle.;

Steps to test

  1. Open the pages
  2. Confirm that everything looks and works as expected.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 9, 2022 •
edited
Loading

✅ pixel-point-website deploy preview ready

nikvoblikov
nikvoblikov reviewed Dec 9, 2022
View reviewed changes
src/components/shared/title-animation/title-animation.jsx Outdated
>
{value}{' '}
</motion.span>
<LazyMotion features={domAnimation}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to wrap the entire element </> in because now there might be problems with

  • — they might lost key

    •

    sashasushko
    sashasushko suggested changes Dec 28, 2022
    View reviewed changes
    Copy link

    @sashasushko sashasushko left a comment •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    services/web-development page was broken

    изображение

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @nikvoblikov nikvoblikov nikvoblikov left review comments

    @sashasushko sashasushko sashasushko requested changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @Den-Bratchikov @sashasushko @nikvoblikov