New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the race condition during create initial connection #64

Merged

proAlexandr merged 1 commit into pixel-point:master from madogiwa:bug/fix-race-condition

Apr 1, 2021

Contributor

madogiwa commented May 30, 2020

I think that this PR is likely to resolve issue #63.

Below is an example sequence to describe the problem fixed by the PR.

Execute await createWS at

kube-forwarder/src/renderer/lib/k8s-port-forwarding-patch.js

Line 55 in c62fe44

ws = await createWS()

and wait for it to finish.
processData is called, ws is created at

kube-forwarder/src/renderer/lib/k8s-port-forwarding-patch.js

Line 29 in c62fe44

ws = await createWS()

and sent data using ws.
await createWS is finished, ws is overwritten to a new connection.
processData is called again, the data is sent using the new ws.

I don't know the specific reason, but sending data from a different WS along the way seems to cause TLS issues.


          Fixed the race condition during create initial connection.

d6b847d

proAlexandr merged commit 1998548 into pixel-point:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet