fix: Add expiration date and time for bindings #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hi @KsaweryZietara. These properties are absolutely in the spec at v2.17, but as far as I'm aware, the main platform that implements OSBAPI - CloudFoundry - only supports up to version v2.15. It might be that my information is out of date, but I just wanted to check that you have a platform that will provide the properties, as it would not help anyone to merge this PR only to find that the platform does not provide the properties anyway. |
KsaweryZietara
changed the title
|
Hi @blgm, the platform in which our broker is registered supports 2.17 |
|
Hi @blgm, when will the changes be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to OSB API Spec, the Binding Object contains a Metadata Object with
expires_atandrenew_beforewhich are missing in the current implementation.expires_atwas introduces in OSB API 2.16 andrenew_beforein 2.17.