Expose BFF API #251
Merged
Expose BFF API #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs, but it is still present on the /api endpoints.
carlschroedl
commented
Nov 16, 2018
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
| /** | |||
| * @SWG\Swagger( | |||
| * basePath="/api", | |||
| * basePath="/", | |||
There was a problem hiding this comment.
I changed this because I wanted the /open-prefixed services to be featured in the Swagger documentation, not just the /api-prefixed services.
carlschroedl
commented
Nov 16, 2018
| @@ -44,7 +44,7 @@ | |||
| |-------------------------------------------------------------------------- | |||
| */ | |||
| 'middleware' => [ | |||
| 'api' => ['web', 'auth'], | |||
| 'api' => [], | |||
There was a problem hiding this comment.
This removes auth from the Swagger HTML GUI that documents our REST APIs. The APIs themselves still require auth.
|
I read the Codacy report. I fixed some of the issues it identified. I choose not to fix the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of #234 by building and exposing a BFF API (POST /open/try). This PR also includes a human interface for the service (GET /open/try). This PR does not complete #234 because it does not switch existing pivot election results calculation to use the new BFF API.