-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(meson): only build on Linux #986
Conversation
README.md
Outdated
@@ -252,3 +252,5 @@ int main() { | |||
## Project status | |||
|
|||
Pistache hasn't yet hit the 1.0 release. This means that the project is _unstable_ but not _unusable_. In fact, most of the code is production ready; you can use Pistache to develop a RESTful API without issues, but the HTTP client has a few issues in it that make it buggy. | |||
|
|||
<b id="linux-only">\*</b> While most code uses modern C++, Pistache makes use of some Linux-specific APIs where the standard library doesn't provide alternatives, and works only on that OS. See [#6](https://github.com/pistacheio/pistache/issues/6#issuecomment-242398225) for details. If you know how to help, feel free to open an issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are already lots of open issues. I would reword to "please contribute a PR to add support for your desired platform." Note that such a platform will need automated unit test coverage, which might complicate things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's better, I didn't know how to word it, thanks :)
Regarding unit tests I think that's a smaller issue. The tests would be the same, as the system calls are an implementation detail; it would be sufficient to run the tests on the supported OS (correct me if I'm wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this note.
related to pistacheio#41 related to pistacheio#183 related to pistacheio#760 closes pistacheio#960 related to pistacheio#985 related to pistacheio#6 related to pistacheio#538 related to pistacheio#649 related to pistacheio#741 related to pistacheio#874 closes pistacheio#525
7ce5da3
to
e4c8cfc
Compare
I am fine with this PR. Kip, and thoughts? if not, i'll merge it later today. |
Deferring here to you @dennisjenkins75. I'm fine with it. |
related to #41
related to #183
related to #760
closes #960
related to #985
related to #6
related to #538
related to #649
related to #741
related to #874
closes #525