Feat: Add method to extract HTTP Bearer token from Authorisation header. #1258
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiplingw
requested changes
Oct 27, 2024
| if (!hasMethod<Authorization::Method::Bearer>()) | ||
| throw std::runtime_error("Authorization header does not use Bearer method."); | ||
|
|
||
| const std::string token(value_.begin() + std::string("Bearer ").length(), value_.end()); |
There was a problem hiding this comment.
This is a problem. You need to make sure that there was a properly formatted token after Bearer . Otherwise you could end up with a scenario where the client sends a malformed request, perhaps intentionally, and it takes down the server.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
+ Coverage 75.60% 76.31% +0.70%
==========================================
Files 56 57 +1
Lines 8733 9815 +1082
==========================================
+ Hits 6603 7490 +887
- Misses 2130 2325 +195 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds a method to extract HTTP Bearer token from the Authorisation header, thus closing #1257.