fix: buffer overflow with strtol #1251
Merged
+62
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1193
The buffer overflow is fixed and checked with the fuzzing test but I would still appreciate feedback about the correctness of the parsing part. The main differences between
strtol
andfrom_chars
as it was said here:1/ from_chars does not ignore leading white space, strtol does.
2/ from_chars does not recognize a leading "+" sign (or signs), whereas strtol treats a leading plus (or pluses) as indicating that the value is positive, which is the default in any case.
I didn't add ignoring leading spaces because the code does it before
from_chars
. Also, I didn't find in many RFCs that leading+
is allowed.