Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accept header serialization #1235

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

EmilienKia
Copy link
Contributor

Hello there,

Here is a small naive implementation of serialization (write) of Accept header.
It can be useful to use this header object at client side.

Please not that I have split in multiple commits, including the modification of the version.txt and some small modifications of a test file according to clang-format recommendation, to not block commits, even if it is not related to my modifications.

Bests.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (15a6d96) to head (9c0b0e4).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/common/http_header.cc 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   76.12%   77.55%   +1.43%     
==========================================
  Files          58       55       -3     
  Lines        9901     7409    -2492     
==========================================
- Hits         7537     5746    -1791     
+ Misses       2364     1663     -701     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Tachi107 Tachi107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Emilien, thanks for the patch! This looks good to me.

@kiplingw kiplingw merged commit eddff16 into pistacheio:master Aug 29, 2024
124 of 134 checks passed
@kiplingw
Copy link
Member

Thanks @EmilienKia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants