-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): Crash if remove not existing route #1209
Conversation
e222d00
to
8bd3683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Just one minor request regarding the newly added test. Otherwise, this looks good to me :)
It seems that this patch is causing test failures on RHEL 9 with the |
@Tachi107 Thanks for the suggestion with |
b0bdfd3
to
549f1f2
Compare
Sorry, accidentally pushed my local changes for fuzzing, reverted them. |
Yeah making the error message the same is definitely a good choice! Still, the new test is consistently failing on RHEL 9, do you think you know why this is the case? |
There was an issue with
|
ca56c19
to
8ae6b61
Compare
The fix looks good to me too. Merging! |
One more crash was found by fuzzer in
router.cc
. I've added unit tests that cover the "removeRoute" function, uncommented a corresponding line in the fuzzer, and renamed corpus files to their SHA1 hashes.