Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Wanted to share my the findings here.
except *
andnogil
in Cython files are due to compiler warnings, shouldn't affect anything.noexcept
in many functions is due to the acquiring of gil to check exceptions. but in past versions of Cython functions without explicit declaration ofexcept
would "swallow" exceptions. so this change should not affect anything. related make gensim CI great again #3488 , Cython linkgensim/test/test_word2vec.py::TestWord2VecModel::test_similarities
which should be due to changes in numpy datatype promotions linkI don't have the expertise or the time to fix these failing tests, just wanted to give a head start to anyone willing.
cc: @hechth
related #3562