Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable esModuleInterop #375

Closed
wants to merge 7 commits into from
Closed

fix: disable esModuleInterop #375

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0169d1a
fix: use CJS imports
SimenB Jul 14, 2023
9c8c82b
fix: disable `esModuleInterop`
SimenB Jul 14, 2023
7b7fa0c
Merge branch 'current' into disable-esModuleInterop
metcoder95 Aug 23, 2023
fd2a825
Merge branch 'current' into disable-esModuleInterop
SimenB May 13, 2024
123ee83
strict assert
SimenB May 13, 2024
39acbe3
rollback `require` change
SimenB May 13, 2024
bd01d58
Merge branch 'current' into disable-esModuleInterop
metcoder95 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { availableParallelism } from 'os';
import { fileURLToPath, URL } from 'url';
import { resolve } from 'path';
import { inspect, types } from 'util';
import assert from 'assert';
import { strict as assert } from 'assert';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the change to use strict is visible to consumers, but assert is used as a function, so we need to tweak this import

import { Histogram, RecordableHistogram, createHistogram, performance } from 'perf_hooks';
import {
READY,
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"esModuleInterop": true,
"esModuleInterop": false,

"resolveJsonModule": true, /* Include modules imported with '.json' extension */
"forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
Expand Down