Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix testbed findBody function #251

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: fix testbed findBody function #251

merged 1 commit into from
Aug 7, 2023

Conversation

zOadT
Copy link
Collaborator

@zOadT zOadT commented Aug 6, 2023

The return values for queryAABB were swapped: Returning false stops the query, true continues it.

Previously, if there are two fixtures in an AABB and the first happens to fail the testPoint test, the other one wouldn't even be tested. This lead to bugs in the 8-Ball example.

@shakiba shakiba merged commit 849f0e7 into master Aug 7, 2023
1 check passed
@shakiba shakiba deleted the findBody-fix branch August 7, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants