Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 2356 - version-prerelease #525

Merged
merged 15 commits into from
Apr 24, 2024
Merged

Build 2356 - version-prerelease #525

merged 15 commits into from
Apr 24, 2024

Conversation

pipedrive-bot
Copy link

No description provided.

@youssef-saber-3 youssef-saber-3 changed the base branch from master to typescript-rc April 24, 2024 10:03
Copy link
Contributor

@Reivilo85k Reivilo85k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youssef-saber-3 youssef-saber-3 added the npm-ready-for-publish used for deployment label Apr 24, 2024
@youssef-saber-3 youssef-saber-3 added npm-ready-for-publish used for deployment and removed npm-ready-for-publish used for deployment labels Apr 24, 2024
@pipedrive-bot-dora
Copy link

Neodora Analysis ⚠

⚠ Missing or invalid timeout in Github Workflow

Message: Github workflow timeout-minutes must be set with a value less or equal to 60 for every job that is not using a reusable workflow

Workflow file Job name Actual timeout Expected
on-pd-bot-pr-opened.yml on_pr_opened Not found <= 60

🔍 How to fix it

⚠ Missing cache in Github Workflow

Message: Github workflow should be using caching when step uses actions/setup-node

Workflow file Job name Step index Actual cache value Expected cache value
on-commit.yml test-runtime 2 Not found npm

🔍 How to fix it

⚠ Missing cache in Github Workflow

Message: Github workflow should be using caching when step uses actions/setup-node

Workflow file Job name Step index Actual cache value Expected cache value
on-pd-bot-pr-opened.yml on_pr_opened 2 Not found npm

🔍 How to fix it

⚠ Incorrect runner in Github Workflow

Message: Github workflow must run on a self-hosted runner

Workflow file Job name Actual runs-on value Expected runs-on value
on-commit.yml test-runtime ubuntu-latest Any of [eks-runner, eks-runner-php, eks-runner-nano, eks-runner-debug, eks-runner-compute, eks-runner-cd, eks-runner-ci, eks-runner-neodora, eks-runner-neodora-bulk, eks-runner-secops]

🔍 How to fix it

⚠ Incorrect runner in Github Workflow

Message: Github workflow must run on a self-hosted runner

Workflow file Job name Actual runs-on value Expected runs-on value
on-pd-bot-pr-opened.yml on_pr_opened ubuntu-latest Any of [eks-runner, eks-runner-php, eks-runner-nano, eks-runner-debug, eks-runner-compute, eks-runner-cd, eks-runner-ci, eks-runner-neodora, eks-runner-neodora-bulk, eks-runner-secops]

🔍 How to fix it

Commit c2b468f Job 391279

pipedrive-bot pushed a commit that referenced this pull request Apr 24, 2024
@pipedrive-bot pipedrive-bot merged commit c2b468f into typescript-rc Apr 24, 2024
2 checks passed
@pipedrive-bot pipedrive-bot deleted the 2356 branch April 24, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants