Merge pull request #34 from chyipin/fix_get_all

Fix getAll params
pipedrive · Dec 16, 2016 · cc9b85e · cc9b85e
2 parents ec2d987 + 512b737
commit cc9b85e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/lib/Pipedrive.js b/lib/Pipedrive.js
@@ -182,11 +182,6 @@ THE SOFTWARE.
 				params = {};
 			}
 
-			params = _.extend({}, params, {
-				start: start,
-				limit: perPage
-			});
-
 			var collection = [],
 				self = this,
 				page = 0,
@@ -197,7 +192,11 @@ THE SOFTWARE.
 				if (!self[resource]) {
 					throw new Error(resource+' is not supported object type for getAll()');
 				}
-				self[resource].getAll(params, function(err, models) {
+				var pageParams = _.extend({}, params, {
+					start: start,
+					limit: perPage
+				});
+				self[resource].getAll(pageParams, function(err, models) {
 					if (err) {
 						return callback(err);
 					} else {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pipedrive",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "description": "Pipedrive REST client for NodeJS",
   "keywords": [
     "pipedrive",