DTL-5457 Install CI/CD for app-extensions-sdk #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moser-ss
requested changes
Oct 8, 2024
| uses: pipedrive-actions/github-actions-workflows/.github/workflows/reusable_cicd-npm-publish.yml@master | ||
| with: | ||
| revision: ${{ github.event.pull_request.head.ref }} | ||
| supported_versions: '[18]' |
There was a problem hiding this comment.
Remove this, lets keep with the default we have in the .nvmrc
CHANGELOG.md
Outdated
| @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| - Migrate publish flow from Jenkins to GitHub Actions | |||
| - Fix Owner name | |||
Moser-ss
approved these changes
Oct 8, 2024
maximlishchenko
added
npm-version-patch
CHANGELOG.md
Outdated
Comment on lines
11
to
12
| - Migrate publish flow from Jenkins to GitHub Actions | ||
| - Add devops-tooling as owner for .github/workflows/cicd_* |
There was a problem hiding this comment.
Is it necessary to include these details in public changelog?
If there even is a need to release a new version, I would keep this information more vague. If it can just be merged to master, then I would exclude adding changelog at all 🤔
There was a problem hiding this comment.
I updated the readme to be more vague. The patch label is needed to test that the release process is working.
AndreasSaltsberg
approved these changes
Oct 10, 2024
maximlishchenko
added
npm-ready-for-publish
pipedrive-public-gha-bot
bot
deleted the
install-cicd-app-extensions-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pipedrive.atlassian.net/browse/DTL-5457