Register the on_error handler #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Jan 18, 2025
| if self._input: | ||
| await self._input.push_error(ErrorFrame(error)) | ||
| if self._output: | ||
| await self._output.push_error(ErrorFrame(error)) |
There was a problem hiding this comment.
I think it should be more like:
if self._input and self._output:
await self._input.push_error(ErrorFrame(error))
elif self._input:
await self._input.push_error(ErrorFrame(error))
else
await self._output.push_error(ErrorFrame(error))
There was a problem hiding this comment.
Or
if (self._input and self._output) or self._input:
await self._input.push_error(ErrorFrame(error))
else
await self._output.push_error(ErrorFrame(error))
There was a problem hiding this comment.
What about this?
if self._input is not None:
await self._input.push_error(error_frame)
elif self._output is not None:
await self._output.push_error(error_frame)
else:
logger.error("Both input and output are None while trying to push error")
raise RuntimeError("No valid input or output channel to push error")
Just pushed that.
There was a problem hiding this comment.
Ah, yes! That would work. No need for is not None though.
markbackman
force-pushed
the
mb/add-on-error-callback
branch
from
ef95ca1 to
6c9c1e1
Compare
aconchillo
approved these changes
Jan 18, 2025
|
LGTM. Just added one nit comment |
markbackman
force-pushed
the
mb/add-on-error-callback
branch
from
6c9c1e1 to
e049ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
This PR went stale: #568. I'm doing clean up, so took a quick crack at it. @aconchillo is this along the lines of what you were thinking for the TODO?