Skip to content

Use chan only to notify command is done to avoid race condition

Codecov / codecov/project succeeded Sep 30, 2024 in 0s

23.95% (+0.00%) compared to c1a06aa

View this Pull Request on Codecov

23.95% (+0.00%) compared to c1a06aa

Details

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.95%. Comparing base (c1a06aa) to head (6e7b336).

Files with missing lines Patch % Lines
pkg/app/launcher/cmd/launcher/binary.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5244   +/-   ##
=======================================
  Coverage   23.95%   23.95%           
=======================================
  Files         437      437           
  Lines       46997    47005    +8     
=======================================
+ Hits        11258    11260    +2     
- Misses      34835    34840    +5     
- Partials      904      905    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.