Use chan only to notify command is done #5244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
|
I'll run the test 5 times and make this PR ready for review if all tests are passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5244 +/- ##
==========================================
+ Coverage 23.95% 23.96% +0.01%
==========================================
Files 437 437
Lines 46997 47005 +8
==========================================
+ Hits 11258 11267 +9
Misses 34835 34835
+ Partials 904 903 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
|
I realized there are no test for the result of GracefulStop, so I added that. |
The tests are passed 5 times. https://github.com/pipe-cd/pipecd/actions/runs/11100844567/job/30838021571 
|
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Warashi
changed the title
t-kikuc
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The original IsRunning method has a bug when the command exits with an error.
After the command is done with an error, IsRunning returns true once if GracefulStop is not called.
This comes from using
chan errorto both pass the result and notify the finish.This PR splits these things to
chan struct{}andatomic.Pointer[error].Which issue(s) this PR fixes:
The flaky test
TestGracefulStopCommand.Fixes #4630
Does this PR introduce a user-facing change?: