Set the envoy retry policy for external-authz filter #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Warashi
commented
Sep 6, 2024
Comment on lines
+51
to
+65
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb | ||
| {{- if .Values.cors.enabled }} | ||
| - name: envoy.filters.http.cors | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.cors.v3.Cors | ||
| {{- end }} | ||
| - name: envoy.filters.http.grpc_stats | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.grpc_stats.v3.FilterConfig | ||
| stats_for_all_methods: true | ||
| enable_upstream_stats: true | ||
| - name: envoy.filters.http.router | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router |
There was a problem hiding this comment.
We have to set these to bump the envoy version
| @@ -25,7 +25,7 @@ spec: | |||
| {{- end }} | |||
| containers: | |||
| - name: envoy | |||
| image: envoyproxy/envoy-alpine:{{ .Values.gateway.imageTag }} | |||
| image: envoyproxy/envoy:{{ .Values.gateway.imageTag }} | |||
There was a problem hiding this comment.
envoy-alpine has stopped updating 2 years ago
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
=======================================
Coverage 22.86% 22.86%
=======================================
Files 420 420
Lines 45247 45245 -2
=======================================
Hits 10344 10344
+ Misses 34108 34106 -2
Partials 795 795 ☔ View full report in Codecov by Sentry. |
Warashi
changed the title
khanhtc1202
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I saw the envoy access log sometimes records UAEX (UnauthorizedExternalService) errors even if the ext-authz service returns them as OK.
I checked the admin port of the envoy and realized the tx_reset had occurred.
I don't know how to reduce the tx_reset, so I want to try the retry_policy.
When we use the retry_policy, we have to bump the envoy version.
So, I bump the envoy version to the latest, then I configured the retry_policy.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: